fix(i18n): use the placeholder names the code passes (lunaria-ignore) by owgreen-dev · Pull Request #3311 · npmx-dev/npmx.dev

owgreen-dev · 2026-10-06T10:00:59Z

🔗 Linked issue

Closes #3310

📚 Description

The fix described in #3310.

agentscanapp · 2026-10-06T10:01:05Z

Thanks for opening this pull request! 🎉

We really appreciate you taking the time to contribute, @owgreen-dev.

A maintainer will take a look as soon as they can. In the meantime, please make sure that:

the description explains what changed and why
any related issues are linked
existing tests still pass

If anything needs adjusting we'll leave comments here. Thanks again!

vercel · 2026-10-06T10:01:05Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
npmx.dev	Ready	Preview	Oct 10, 2026 2:12pm UTC

2 Skipped Deployments

Project	Deployment	Actions	Updated
docs.npmx.dev	Ignored	Preview	Oct 10, 2026 2:12pm UTC
npmx-lunaria	Ignored		Oct 10, 2026 2:12pm UTC

github-actions · 2026-10-06T10:01:56Z

Lunaria Status Overview

🌑 This pull request will not trigger status changes.

Learn more

Lunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: lunaria-ignore.

You can change this by either removing the keyword above from the PR's title, or modifying the tracking.ignoredKeywords property in your Lunaria configuration file.

Tracked Files

Note

The notes below indicate what would happen if the pull request is merged when triggering status changes. Since a ignored keyword was found in the PR's title, the status changes indicated below won't be applied.

File	Note
i18n/locales/ar-EG.json	Localization changed, will be marked as complete. 🔄️
i18n/locales/de.json	Localization changed, will be marked as complete. 🔄️
i18n/locales/nl.json	Localization changed, will be marked as complete. 🔄️
i18n/locales/pl-PL.json	Localization changed, will be marked as complete. 🔄️
i18n/locales/ro-RO.json	Localization changed, will be marked as complete. 🔄️
i18n/locales/tr-TR.json	Localization changed, will be marked as complete. 🔄️
i18n/locales/zh-TW.json	Localization changed, will be marked as complete. 🔄️

Warnings reference

Icon	Description
🔄️	The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

coderabbitai · 2026-10-06T10:02:05Z

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: Repository: npmx-dev/npmx.dev/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: 41e1de32-9b79-4f58-af0c-a017a6efd465

📥 Commits

Reviewing files that changed from the base of the PR and between 03ff7ff and 47b06f4.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: npmx-dev/npmx.dev/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: ae96ee20-8d3d-4793-8893-1da1e6b1913c

📥 Commits

Reviewing files that changed from the base of the PR and between 18b504e and 03ff7ff.

📒 Files selected for processing (1)

i18n/locales/nl.json

🚧 Files skipped from review as they are similar to previous changes (1)

i18n/locales/nl.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Summary

Summary by CodeRabbit

Bug Fixes
- Corrected translated profile, accessibility, pagination, chart, package and vulnerability text across Arabic, German, Dutch, Polish, Romanian, Turkish and Traditional Chinese.
- Updated displayed counts, package and version details, pagination ranges, chart descriptions and vulnerability summaries to show the appropriate information in each locale.

📝 Summary

Walkthrough

Translation strings in seven locales now use interpolation placeholders that match the values supplied by the application. The Turkish invitation and vulnerability strings and the Arabic anomaly-range string also have updated wording.

Changes

Locale interpolation updates

Layer / File(s)	Summary
Profile, invitation and anomaly strings `i18n/locales/ar-EG.json`, `i18n/locales/tr-TR.json`	Profile SEO strings use `{handle}`. The Turkish invitation string includes the handle. Named anomaly strings use package names; the Arabic string also displays the start and end values.
Counts and package labels `i18n/locales/tr-TR.json`, `i18n/locales/nl.json`	Turkish count and pagination strings use updated placeholders. The Turkish package-removal and vulnerability strings use the supplied values. Dutch pagination uses `{range}`.
Accessibility, tooltip and chart strings `i18n/locales/de.json`, `i18n/locales/pl-PL.json`, `i18n/locales/ro-RO.json`, `i18n/locales/zh-TW.json`	The accessibility, tooltip and chart strings use updated interpolation placeholders.

Priority: ➖ Normal

Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 03ff7

No merge-blocking issue is identified for the selected translation change; normal checks can proceed.

Pre-merge checks | 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check		The title clearly identifies the i18n fix and states that translations now use the placeholder names supplied by the code.
Description check		The description identifies the linked issue and states that this pull request implements its i18n fix, which matches the changeset.
Linked Issues check		The changes address the coding requirements in `#3310`. They update placeholders in ar-EG, de, nl, pl-PL, ro-RO, tr-TR and zh-TW to match the values supplied by the code. They also update the Arabic ano…
Out of Scope Changes check		The changes are limited to translation placeholder and wording corrections in the seven locales named by `#3310`. The summaries show no unrelated source, test, configuration, or documentation changes.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

codecov · 2026-10-06T10:02:54Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

WilcoSp · 2026-10-06T20:40:58Z

hey nice that you caught these. with NL with {instellingen} I did also caught it and also fixed it at #3283.
with {range} I didn't notice it was changed, hopefully #1761 will eventually fix it

at least with Dutch (nl) you've a ✅ from me

graphieros

👍🌿

github-actions · 2026-10-10T14:22:48Z

Thanks for your first contribution, @owgreen-dev! 🎊

We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role.

fix(i18n): use the placeholder names the code passes

18b504e

vercel Bot deployed to Preview – npmx.dev October 6, 2026 10:03 View deployment

owgreen-dev changed the title ~~fix(i18n): use the placeholder names the code passes~~ fix(i18n): use the placeholder names the code passes (lunaria-ignore) Oct 6, 2026

Merge branch 'main' into fix/i18n-renamed-placeholders

03ff7ff

vercel Bot deployed to Preview – docs.npmx.dev October 10, 2026 14:09 View deployment

vercel Bot deployed to Preview – npmx.dev October 10, 2026 14:09 View deployment

Merge branch 'main' into fix/i18n-renamed-placeholders

47b06f4

vercel Bot deployed to Preview – npmx.dev October 10, 2026 14:12 View deployment

graphieros approved these changes Oct 10, 2026

View reviewed changes

graphieros added this pull request to the merge queue Oct 10, 2026

Merged via the queue into npmx-dev:main with commit cf8f9a0 Oct 10, 2026
24 checks passed

github-actions Bot mentioned this pull request Oct 10, 2026

chore: release v0.20.0 #3244

Open

Navigation Menu

Repository navigation

fix(i18n): use the placeholder names the code passes (lunaria-ignore) - #3311

fix(i18n): use the placeholder names the code passes (lunaria-ignore)#3311
graphieros merged 3 commits into
npmx-dev:mainfrom
owgreen-dev:fix/i18n-renamed-placeholders

owgreen-dev commented Oct 6, 2026

Uh oh!

agentscanapp Bot commented Oct 6, 2026

Uh oh!

vercel Bot commented Oct 6, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 6, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 6, 2026 •

edited

Loading

Review skipped

Summary by CodeRabbit

Walkthrough

Changes

Uh oh!

codecov Bot commented Oct 6, 2026

Uh oh!

WilcoSp commented Oct 6, 2026

Uh oh!

graphieros left a comment

Uh oh!

Uh oh!

github-actions Bot commented Oct 10, 2026

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

owgreen-dev commented Oct 6, 2026

🔗 Linked issue

📚 Description

Uh oh!

agentscanapp Bot commented Oct 6, 2026

Thanks for opening this pull request! 🎉

Uh oh!

vercel Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Lunaria Status Overview

Tracked Files

Uh oh!

coderabbitai Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Summary by CodeRabbit

Walkthrough

Changes

Uh oh!

codecov Bot commented Oct 6, 2026

Codecov Report

Uh oh!

WilcoSp commented Oct 6, 2026

Uh oh!

graphieros left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Oct 10, 2026

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel Bot commented Oct 6, 2026 •

edited

Loading

github-actions Bot commented Oct 6, 2026 •

edited

Loading

coderabbitai Bot commented Oct 6, 2026 •

edited

Loading